Support kCMPixelFormat_32BGRA and add github action for running tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioalessandro
changed the title
darioalessandro
commented
Dec 19, 2024
nokhwa-core/src/pixel_format.rs
Outdated
| @@ -405,9 +496,10 @@ impl FormatDecoder for LumaAFormat { | |||
| /// let image: ImageBuffer<Rgb<u8>, Vec<u8>> = buffer.to_image::<YuyvFormat>(); | |||
| /// ``` | |||
| #[derive(Copy, Clone, Debug, Default, Hash, Ord, PartialOrd, Eq, PartialEq)] | |||
| pub struct YuyvFormat; | |||
| pub struct I420Format; | |||
There was a problem hiding this comment.
This was never YUYV it was always meant to be i420
darioalessandro
changed the title
darioalessandro
changed the title
darioalessandro
commented
Dec 26, 2024
.github/workflows/examples.yml
Outdated
| @@ -29,4 +29,4 @@ jobs: | |||
| - name: Cargo Check | |||
| run: | | |||
| cd examples/threaded-capture | |||
| cargo check | |||
darioalessandro
commented
Dec 26, 2024
| 2 => Mat::new_rows_cols_with_data::<GA8>(resolution.width() as i32, resolution.height() as i32, cast_slice(data)), | ||
| 3 => Mat::new_rows_cols_with_data::<RGB8>(resolution.width() as i32, resolution.height() as i32, cast_slice(data)), | ||
| 4 => Mat::new_rows_cols_with_data::<RGBA8>(resolution.width() as i32, resolution.height() as i32, cast_slice(data)), | ||
| 1 => Mat::new_rows_cols_with_data::<G8>( |
There was a problem hiding this comment.
this is just cargo fmt
darioalessandro
commented
Dec 26, 2024
| use crate::error::NokhwaError; | ||
| use crate::pixel_format::FormatDecoder; | ||
| use crate::types::{FrameFormat, Resolution}; | ||
| use bytemuck::{cast_slice, Pod, Zeroable}; |
darioalessandro
commented
Dec 26, 2024
| @@ -77,6 +77,16 @@ impl FormatDecoder for RgbFormat { | |||
| .collect()), | |||
| FrameFormat::RAWRGB => Ok(data.to_vec()), | |||
| FrameFormat::NV12 => nv12_to_rgb(resolution, data, false), | |||
| FrameFormat::BGRA => { | |||
There was a problem hiding this comment.
this is the meat of the change
darioalessandro
commented
Dec 26, 2024
| @@ -0,0 +1,38 @@ | |||
|
|
|||
| # Assets | |||
There was a problem hiding this comment.
Documenting how I added the test images and the license for the pyramid picture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.